Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #5070: Display empty answer message in image click interaction #5316

Merged
merged 17 commits into from
Feb 27, 2024
Merged

Fix part of #5070: Display empty answer message in image click interaction #5316

merged 17 commits into from
Feb 27, 2024

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Jan 20, 2024 •
edited
Loading

Explanation

Fix part of #5070, In Image interaction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer.

image_blank_input.webm

(Grammar error fixed )

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Jan 20, 2024
@adhiamboperes adhiamboperes mentioned this pull request Jan 22, 2024
Closed
12 tasks
@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as ready for review January 23, 2024 05:52
@Vishwajith-Shettigar Vishwajith-Shettigar requested a review from a team as a code owner January 23, 2024 05:52
@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes, PTAL.

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 23, 2024

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

@Vishwajith-Shettigar Vishwajith-Shettigar changed the title Fix part of #5070: Display empty answer message in image click input interaction Fix part of #5070: Display empty answer message in image click interaction Jan 24, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 5, 2024

Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 5, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 5, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 12, 2024

Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 12, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 12, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 19, 2024

Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 19, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 19, 2024
adhiamboperes
adhiamboperes requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar! I have left some comments.

...org/oppia/android/app/player/state/itemviewmodel/ImageRegionSelectionInteractionViewModel.kt Outdated Show resolved Hide resolved
...org/oppia/android/app/player/state/itemviewmodel/ImageRegionSelectionInteractionViewModel.kt Show resolved Hide resolved
...org/oppia/android/app/player/state/itemviewmodel/ImageRegionSelectionInteractionViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/testing/ImageRegionSelectionTestFragmentPresenter.kt Outdated Show resolved Hide resolved
...src/sharedTest/java/org/oppia/android/app/testing/ImageRegionSelectionInteractionViewTest.kt Show resolved Hide resolved
@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes, PTAL.

@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 26, 2024

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

adhiamboperes
adhiamboperes approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Vishwajith-Shettigar!

@oppiabot oppiabot bot added the PR: LGTM label Feb 26, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 26, 2024

Hi @Vishwajith-Shettigar, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes enabled auto-merge (squash) February 27, 2024 00:59
@adhiamboperes adhiamboperes merged commit 9938779 into oppia:develop Feb 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vishwajith-Shettigar @adhiamboperes